Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research list styles feature #7736

Closed
Reinmar opened this issue Jul 29, 2020 · 2 comments
Closed

Research list styles feature #7736

Reinmar opened this issue Jul 29, 2020 · 2 comments
Assignees
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 29, 2020

Provide a description of the task

Research what CKEditor 4 offers (we should cover these options) and what other editors offer.

Then, let's think about what we can do better than CKEditor 4.

Part of #1031.

@Reinmar Reinmar added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Jul 29, 2020
@Reinmar Reinmar added this to the iteration 35 milestone Jul 29, 2020
@pomek
Copy link
Member

pomek commented Aug 3, 2020

Results of the research what do CKEditor 4 and other editors.

CKEditor 4

  • No option for setting list style in the toolbar
  • Presets/layouts for nested lists do not exist
  • The list-style value is applied on ol or ul element using inline styles

TinyMCE

  • List style option visible in the toolbar (for both kind of lists)
  • Presets/layouts for nested lists do not exist
  • The value is applied to HTML element (like v4)

Quill

At this moment, Quill provides the same options/support as CKEditor 5 (no option for setting list styles).

Google Docs

  • List style option visible in the toolbar
  • Ability for using presets for nested lists
  • GDocs uses div and span elements for rendering lists.

AFAICS, for MVP version, setting the list style value via the toolbar should be enough. List presets will simplify creating nested lists but I am unsure how we will merge two options in single toolbar item (list style, presets for nested lists).

@pomek
Copy link
Member

pomek commented Aug 7, 2020

After an internal talk with the team, we were considering how to use our UI library in the most efficient way, also keeping in mind that we want to support the content produced by CKEditor 4, we decided to use split buttons on the list (numbered or bulleted) icons. After clicking on them, the UI will show options for setting the list style.

Also, list styles should be disabled for to-do list.

Since the ticket is about researching and at this moment we have a conclusion, I am closing the ticket and if the rest of the discussion should be continued in #1031.

@pomek pomek closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants