Prevent key conflict and keep iterable behavior #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great at first pass! Lemme figure out what's going on with Circle and get back to this |
|
Cool, thanks! Do you think we should remove |
|
Yes!
…Sent from my phone
On May 8, 2019, at 12:49 PM, Iago Dahlem Lorensini ***@***.***> wrote:
Cool, thanks!
Do you think we should remove localStorage.__STORE__[<key>] references from the README and encourage people to use localStorage[<key>]?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@clarkbw any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #102.
Based on #66 I changed the current implementation of the
LocalStorageclass to be a factory function that uses a Proxy internally.This way we avoid key conflicts and keeps the iterable behavior.
So given the
storageobject, we can callObject.entries/keys/valuesor even just call thestorageobject itself that it will resolve to an object with all and just the stored items in it, as the native implementation does.