Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do the dispatch and action calls come from? #124

Open
mrdulin opened this issue Dec 17, 2020 · 5 comments
Open

Where do the dispatch and action calls come from? #124

mrdulin opened this issue Dec 17, 2020 · 5 comments

Comments

@mrdulin
Copy link

mrdulin commented Dec 17, 2020

There is no mention of redux in the documentation for the test examples

@clarkbw
Copy link
Owner

clarkbw commented Dec 17, 2020

Yes, that's a redux example. Should probably note that above the example.

Would you mind creating a PR to update the README?

@mrdulin
Copy link
Author

mrdulin commented Dec 18, 2020

@clarkbw Is it necessary to introduce redux examples? I think only the basic usage needs to be given.

@clarkbw
Copy link
Owner

clarkbw commented Dec 18, 2020

I think it helps show the async nature of testing.

@kendallroth
Copy link

While I do agree that these examples are beneficial, I would suggest that most of the examples should simply use localStorage.setItem and localStorage.getItem calls (as they are not directly documented anywhere) to reduce confusion.

@flbraun
Copy link
Contributor

flbraun commented Mar 25, 2021

+1 to remove them from the readme. I just checked jest-localstorage-mock out for the first time in a project that doesn't even use redux and was slightly confused until I discovered this issue.
@clarkbw Would you agree to remove them if I file a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants