From edfec621e44e699c0c7057a55caf7554a4b5389b Mon Sep 17 00:00:00 2001 From: James Clarke Date: Sun, 18 Apr 2021 11:46:33 -0700 Subject: [PATCH] CR #3 --- shell/platform/windows/flutter_project_bundle.cc | 2 +- shell/platform/windows/flutter_project_bundle.h | 2 +- shell/platform/windows/flutter_windows_engine.cc | 2 +- shell/platform/windows/flutter_windows_engine.h | 2 +- shell/platform/windows/flutter_windows_winuwp.cc | 3 +-- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/shell/platform/windows/flutter_project_bundle.cc b/shell/platform/windows/flutter_project_bundle.cc index 36851384396d0..787ecd21009e8 100644 --- a/shell/platform/windows/flutter_project_bundle.cc +++ b/shell/platform/windows/flutter_project_bundle.cc @@ -81,7 +81,7 @@ UniqueAotDataPtr FlutterProjectBundle::LoadAotData( FlutterProjectBundle::~FlutterProjectBundle() {} void FlutterProjectBundle::SetSwitches( - std::vector const& switches) { + const std::vector& switches) { engine_switches_ = switches; } diff --git a/shell/platform/windows/flutter_project_bundle.h b/shell/platform/windows/flutter_project_bundle.h index 996ab028de988..3cb5d3ca61622 100644 --- a/shell/platform/windows/flutter_project_bundle.h +++ b/shell/platform/windows/flutter_project_bundle.h @@ -42,7 +42,7 @@ class FlutterProjectBundle { const std::vector GetSwitches(); // Sets engine switches. - void SetSwitches(std::vector const& switches); + void SetSwitches(const std::vector& switches); // Attempts to load AOT data for this bundle. The returned data must be // retained until any engine instance it is passed to has been shut down. diff --git a/shell/platform/windows/flutter_windows_engine.cc b/shell/platform/windows/flutter_windows_engine.cc index 58bd9f3a4cc51..6eee0338354c6 100644 --- a/shell/platform/windows/flutter_windows_engine.cc +++ b/shell/platform/windows/flutter_windows_engine.cc @@ -185,7 +185,7 @@ FlutterWindowsEngine::~FlutterWindowsEngine() { } void FlutterWindowsEngine::SetSwitches( - std::vector const& switches) { + const std::vector& switches) { project_->SetSwitches(switches); } diff --git a/shell/platform/windows/flutter_windows_engine.h b/shell/platform/windows/flutter_windows_engine.h index 247b982e2612f..3dc729b25311b 100644 --- a/shell/platform/windows/flutter_windows_engine.h +++ b/shell/platform/windows/flutter_windows_engine.h @@ -75,7 +75,7 @@ class FlutterWindowsEngine { FlutterDesktopOnPluginRegistrarDestroyed callback); // Sets switches member to the given switches. - void SetSwitches(std::vector const& switches); + void SetSwitches(const std::vector& switches); FlutterDesktopMessengerRef messenger() { return messenger_.get(); } diff --git a/shell/platform/windows/flutter_windows_winuwp.cc b/shell/platform/windows/flutter_windows_winuwp.cc index b14a5f6156421..90363154fc207 100644 --- a/shell/platform/windows/flutter_windows_winuwp.cc +++ b/shell/platform/windows/flutter_windows_winuwp.cc @@ -29,9 +29,8 @@ static flutter::FlutterWindowsEngine* EngineFromHandle( return reinterpret_cast(ref); } -// Resturns a list of discrete arguments splitting the input using a ",". +// Returns a list of discrete arguments splitting the input using a ",". std::vector SplitCommaSeparatedString(const std::string& s) { - // Split by ','. std::vector components; std::istringstream stream(s); std::string component;