Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare fixity of exponentiation (Clash.Class.Exp) #2818

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Declare fixity of exponentiation (Clash.Class.Exp) #2818

merged 1 commit into from
Oct 9, 2024

Conversation

DigitalBrains1
Copy link
Member

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

christiaanb
christiaanb approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@christiaanb christiaanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the omission from the original PR was an oversight. So LGTM

@DigitalBrains1
Copy link
Member Author

I want to make the changelog a bit more readable for people not used to the jargon. Simply did not get round to that improvement; tomorrow!

@DigitalBrains1 DigitalBrains1 enabled auto-merge (squash) October 9, 2024 15:44
@DigitalBrains1 DigitalBrains1 merged commit 5706eaf into master Oct 9, 2024
13 checks passed
@DigitalBrains1 DigitalBrains1 deleted the exp-fixity branch October 9, 2024 17:29
mergify bot pushed a commit that referenced this pull request Oct 9, 2024
@DigitalBrains1 @mergify
Declare fixity of exponentiation (Clash.Class.Exp) (#2818)
46f4fe0 
(cherry picked from commit 5706eaf)
@mergify mergify bot mentioned this pull request Oct 9, 2024
Merged
2 tasks
DigitalBrains1 added a commit that referenced this pull request Oct 9, 2024
@mergify @DigitalBrains1
Declare fixity of exponentiation (Clash.Class.Exp) (#2818) (#2826)
e012767 
(cherry picked from commit 5706eaf)

Co-authored-by: Peter Lebbing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiaanb christiaanb christiaanb approved these changes

Assignees
No one assigned
Labels
backport 1.8 needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DigitalBrains1 @christiaanb