Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some classes don't fit in list on small page sizes #205

Open
meshy opened this issue Nov 6, 2022 · 2 comments
Open

Some classes don't fit in list on small page sizes #205

meshy opened this issue Nov 6, 2022 · 2 comments

Comments

@meshy
Copy link
Contributor

meshy commented Nov 6, 2022

When the homepage viewport is reduced to smaller sizes, some of the class names pop out of their containers.

image

@ghickman
Copy link
Contributor

ghickman commented Nov 7, 2022

A quick fix to this would be to use Bootstrap's overflow class for the smaller viewports (we might even just be able to apply it generally?).

The better fix would be to have the explainer be a column which moves below the classes on smaller viewports, but my guess is that could be more work?

Are you considering an update to bootstrap as part of your big refactoring? If so the quicker fix might be a better choice given the layout engine has changed a couple of times in the major version bumps.

@meshy
Copy link
Contributor Author

meshy commented Nov 7, 2022

The better fix would be to have the explainer be a column which moves below the classes on smaller viewports, but my guess is that could be more work?

That would probably be enough. Another thing that would work at this size (tablet-ish... larger than mobile) would be to reduce the width of the text column, and expand the others. Apologies if the screenshot was misleading -- it's a snippet, not the full viewport.

Are you considering an update to bootstrap as part of your big refactoring?

Besides needing a few small tweaks, I think this version of bootstrap is holding up pretty well, so if I can avoid that for the moment, I will. The nav-bar might be frustrating to fix though. I think there's room for a discussion about a complete re-design, but I'd like to handle that after the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants