Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.1 data #181

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Django 4.1 data #181

merged 2 commits into from
Oct 16, 2022

Conversation

meshy
Copy link
Contributor

@meshy meshy commented Oct 16, 2022

TODO:

@meshy meshy changed the title WIP: Django 4.1 support WIP: Django 4.1 data Oct 16, 2022
@meshy
Copy link
Contributor Author

meshy commented Oct 16, 2022

Because of how the inspect module (which we are using to extract the code) executes the code before delivering it to us, the view_is_async classmethod has already been converted into a bool when we access it.

Rather than fight with the inspect module on this, I'm going to merge as-is, and recommend that we move to a new method of extracting the code in future. LibCST is the first thing to spring to mind, but I'm confident that there are other possibilities. That can wait for another ticket.

@meshy meshy changed the title WIP: Django 4.1 data Django 4.1 data Oct 16, 2022
@meshy meshy merged commit 32d9880 into main Oct 16, 2022
@meshy meshy deleted the django-4.1 branch October 16, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant