Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: callback_url vs metadata_url #88

Closed
maigl opened this issue Apr 19, 2023 · 1 comment · Fixed by #144
Closed

nit: callback_url vs metadata_url #88

maigl opened this issue Apr 19, 2023 · 1 comment · Fixed by #144

Comments

@maigl
Copy link
Contributor

maigl commented Apr 19, 2023

I think we might have a small inconsistency in how to configure callback_url vs metadata_url:
Both URLs getting passed to the provider, both URLs have some suffix: /status and /runner-registration-token when actually called.

https://garmserver/api/v1/callbacks/status
https://garmserver/api/v1/metadata/runner-registration-token

/runner-registration-token is appended in the (openstack) provider (both, the bash version and the go version)
but the /status is appended nowhere, this has to be added directly in the configuration by the user.

I think a symmetric configuration would be much nicer, like this:

[default]
callback_url = "https://garmserver/api/v1/callbacks"
metadata_url = "https://garmserver/api/v1/metadata"

Shall I change that .. or do you prefer the way it is ?

Michael Kuhnt [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

@gabriel-samfira
Copy link
Member

I completely forgot about this one. Yes, we can consolidate the behavior. Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants