Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudNative.CloudEvents.RabbitMq #310

Open
antiblue opened this issue Sep 17, 2024 · 6 comments
Open

CloudNative.CloudEvents.RabbitMq #310

antiblue opened this issue Sep 17, 2024 · 6 comments

Comments

@antiblue
Copy link

Hi, I worked on an AMQP 0.9.1 protocol binding using the RabbitMq.Client.

I followed the "RabbitMQ Protocol Binding for CloudEvents" specification
and looked (of course) at how the AMQP 1.0 bindings here do things.

I would like to create a PR to get this integrated into the sdk-csharp.

@jskeet
Copy link
Contributor

jskeet commented Sep 17, 2024

That sounds fine, yes. Maybe leave this issue open for any discussion about aspects that there isn't code for yet, and create a PR to add the library (and tests).

@jskeet
Copy link
Contributor

jskeet commented Sep 17, 2024

(If the new library can be independent of the existing Amqp library, that would be handy in terms of diamond dependencies etc, but let me know if that doesn't work out. I really don't know a lot about this area I'm afraid.)

@antiblue
Copy link
Author

Yes, I could not use the existing library and the new one does not depend on CloudNative.CloudEvents.Amqp or AMQPNetLite

@antiblue
Copy link
Author

Hi @jskeet I face a strange issue.
I am unable to restore packages on my branch because he basically tries to find itself.

The error message is
[NU1101] Unable to find package CloudNative.CloudEvents.RabbitMq. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages, nuget.org at (0:0)

Any ideas?

@jskeet
Copy link
Contributor

jskeet commented Sep 18, 2024

I'll see if I can find time to pull your branch and reproduce, but I make no guarantees I'm afraid.

@jskeet
Copy link
Contributor

jskeet commented Sep 18, 2024

Got it - the problem is that it's trying to compare the current code with a previous version of the same package (for backward compatibility). Add this into the property group:

<EnablePackageValidation>false</EnablePackageValidation>

... then do a full rebuild. It should work at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants