-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames Add-CloudEvent*Data to Set-CloudEvent*Data #12
Renames Add-CloudEvent*Data to Set-CloudEvent*Data #12
Conversation
Signed-off-by: Dimitar Milov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -98,4 +98,3 @@ if (Test-Path $catalogFilePath) { | |||
# Delete previous catalog file | |||
Remove-Item $catalogFilePath -Confirm:$false | |||
} | |||
New-FileCatalog -Path $OutputDir -CatalogFilePath $catalogFilePath | Out-Null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion: Maybe we can remove the whole step Prepare Module for Publishing although the condition for removing the previous catalog file will never be invoked with the removal of the NewFileCatalog call.
…ld.ps1 Signed-off-by: Dimitar Milov <[email protected]>
…ld.ps1 Signed-off-by: Dimitar Milov <[email protected]>
…:dmilov/sdk-powershell into topic/dmilov/rename-add-data-to-set-data
|
||
.DESCRIPTION | ||
This function adds data to a cloud event object with the provided parameters. | ||
This function sets data into a cloud event object with the provided parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function sets data into a cloud event object with the provided parameters. | |
This function sets data in a cloud event object with the provided parameters. |
…tests Signed-off-by: Dimitar Milov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you want to squash or squash during merge?
I'll squash on merge |
Add-CloudEvent*Data
functions toSet-CloudEvent*Data
#9 renamingAdd-CloudEvent*Data
functions toSet-CloudEvent*Data
. As described in the issue the Add notion is not correct for the functions functionality.Set
verb notion matches the behavior of the functions.