Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft BBS implementation #461

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Draft BBS implementation #461

wants to merge 6 commits into from

Conversation

chris-wood
Copy link
Contributor

Starting as a draft to collect early feedback. I've not checked against all of the test vectors in the draft, but most of the positive cases. I'm interested in feedback on the API at this point. Function internals will be improved in the future PR. Please ignore all of the random comments and notes for myself -- a lot of them are notes to send feedback to the CFRG draft for improvement.

This branch is necessary to support prototype work for a Privacy Pass token type built on BBS.

cc @wbl, @tplooker


// Key generation
// https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-bbs-signatures-03#name-key-generation-operations
func KeyGen(ikm []byte, keyInfo, keyDst []byte) (SecretKey, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this first argument should be the output from crypto/rand.Reader, should there have an internal form for testing and then this function reads from the reader?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, accepting a crypto/rand.Reader instead of raw bytes is better here. I passed the raw seed in for now to expedite checking against the test vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants