v2.0.0 Beta #1538
Replies: 7 comments 16 replies
-
|
Hello. I’m a user of cloudflare kv package with go. # 1 In the process of listing and deleting keys in the namespace, I went through the process of checking This is an example of it. (ver 0.9x) for {
resp, err := s.api.ListWorkersKVKeys(context.Background(), cloudflare.AccountIdentifier(s.accountID), cloudflare.ListWorkersKVsParams{
NamespaceID: s.namespaceID,
Cursor: cursor,
})
if err != nil {
log.Printf("Error occur in ListWorkersKVKeys: %v", err)
return err
}
keys = make([]string, len(resp.Result))
for _, element := range resp.Result {
name := element.Name
keys = append(keys, name)
}
_, err = s.api.DeleteWorkersKVEntries(context.Background(), cloudflare.AccountIdentifier(s.accountID), cloudflare.DeleteWorkersKVEntriesParams{
NamespaceID: s.namespaceID,
Keys: keys,
})
if err != nil {
log.Printf("Error occur in DeleteWorker: %v", err)
return err
}
if len(resp.Cursor) == 0 {
log.Println("No keys left in the namespace")
break
}
cursor = resp.Cursor
}But in v2, I found a # 2 Would you add a flag of If there's something that I'm wrong about, please tell me. :) |
Beta Was this translation helpful? Give feedback.
-
|
👋 thanks for the feedback. as of today, the migration we offer is through the GritQL pattern linked and the manual notes above. we're not able to do a method by method (or even product) deep dive largely because there isn't a 1:1 for all products or methods. at this point, we won't be adding any further migrates to the v0 => v2 plan. for future major versions, we'll be looking to provide more comprehensive auto migrations. for your second point on knowing when the pagination finishes, have you tried the guidance in the README? with |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your reply. I understand the things about migration. And, thanks for noticing me about |
Beta Was this translation helpful? Give feedback.
-
|
What's the future of flarectl once v2 ships? I was just lamenting that the current flarectl doesn't support the rules engine. A full-featured CLI would take my Cloudflare config experience to Cloud 9. I don't see that Stainless supports generating a CLI, but I see there are other tools that claim to be able to do so. Is Cloudflare planning to offer a CLI that's autogenerated from the OpenAPI Spec -- or will it be left to the community to provide something? |
Beta Was this translation helpful? Give feedback.
-
|
there will be a CLI in the future. it won't be |
Beta Was this translation helpful? Give feedback.
-
|
@jacobbednarz , if there's ever an opportunity for customers (enterprise or otherwise) to beta test, count me in. |
Beta Was this translation helpful? Give feedback.
-
|
feel free to shoot me an email betas are generally announced on our socials or the repositories so if you're following there, you should see it pop up. |
Beta Was this translation helpful? Give feedback.
-
|
It would be great to have mocks as a part of the new library. I am incorporating unit tests with my code, and it would be great to be able to just import existing ones. |
Beta Was this translation helpful? Give feedback.
-
|
we don't have plans to export mocks from the library at this point but will note it down for future investigation. a local testing solution is under way, but for now, a mix of prism and our OpenAPI spec meets most needs (when prism works 🙄) |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I'm trying out the v2 library and in general I'm happy with a group-up clean-up. Unfortunately I noticed an issue that prevents me from adopting it and I hope we can resolve it. Currently, the |
Beta Was this translation helpful? Give feedback.
-
|
by default, we intentionally don't want a "clean" client. we are optimising for a zero configuration adoption that will co-exist alongside other tools. we may look at adding another method to do it, however, it's not in the immediate roadmap. other options are also floating around how we handle "blocking" of environment variable blocking which may change this here.
we intentionally have moved it to a client instantion option instead (like HTTP clients) as it is more idiomatic and not sensitive like the other values so less likely to be an environment variable. you can see the docs at: https://github.com/cloudflare/cloudflare-go/blob/v2/option/requestoption.go#L26-L35 if you want to continue using it.
i can't comment on your reasoning here, however, this approach won't work for all endpoints. while API token coverage is pretty good, there are some things that can only be performed with API key/email combo today and not supporting it does limit what you can implement. |
Beta Was this translation helpful? Give feedback.
-
|
@jacobbednarz Thanks. I think the fundamental difference in our thinking is that I view
An inspiring example is the treatment of var DefaultTransport RoundTripper = &Transport{
Proxy: ProxyFromEnvironment,
DialContext: defaultTransportDialContext(&net.Dialer{
Timeout: 30 * time.Second,
KeepAlive: 30 * time.Second,
}),
ForceAttemptHTTP2: true,
MaxIdleConns: 100,
IdleConnTimeout: 90 * time.Second,
TLSHandshakeTimeout: 10 * time.Second,
ExpectContinueTimeout: 1 * time.Second,
}where As for API keys, thanks for the information that not all end points are covered by API tokens yet. (What are they? I'm curious.) That said, my application only needs a handful of endpoints that are covered by API tokens and I still believe it's more future-proof to use API tokens. (Please correct me if I'm wrong.) If my understanding is correct, I do hope there's a way to at least warn about the use of API keys. |
Beta Was this translation helpful? Give feedback.
-
|
@jacobbednarz Updates: I just released a new version of my tool that will also accept variables |
Beta Was this translation helpful? Give feedback.
-
|
thanks for the updates. at the moment, the "clean" or explicit client you're after is still being discussed and working out what that looks like across the board. regarding API tokens, you can check out the new docs at https://developers.cloudflare.com/api-next/ for the endpoints and it will include the available auth schemes. |
Beta Was this translation helpful? Give feedback.
-
|
@jacobbednarz Thanks for the information. The new site looks great! I will take a more careful look later. |
Beta Was this translation helpful? Give feedback.
-
|
This has been fixed I have another question: apparently I don't understand how type AccountGetParams struct {
AccountID param.Field[interface{}] `path:"account_id,required"`
} |
Beta Was this translation helpful? Give feedback.
-
|
the |
Beta Was this translation helpful? Give feedback.
-
|
I see. I will wait for the correction, then. |
Beta Was this translation helpful? Give feedback.
-
|
This has been corrected. (Is there a way to mark this as "done"?) |
Beta Was this translation helpful? Give feedback.
-
|
Regarding error handling, the 2.x approach looks much better than 0.x, but I don't understand this principle about avoiding wrapping:
Why should we avoid wrapping in other cases? |
Beta Was this translation helpful? Give feedback.
-
|
Hello, |
Beta Was this translation helpful? Give feedback.
-
Warning
v2.xof this library is a ground-up rewrite of the SDK, using code generation from our OpenAPI spec.This package should be in a usable state for many projects, but expect frequent minor breaking
changes as we rename methods and types until GA. If this isn't suitable for you project, we recommend
pinning to the
0.xreleases for now.We're working on a new major version of our SDK and are excited to have you test it!
Please use this discussion page as a place to report issues and feedback about the new release.
Install
Code
https://github.com/cloudflare/cloudflare-go/tree/v2
Things we would like feedback on
Migration guide
0.x to 2.x upgrade guide
Beta Was this translation helpful? Give feedback.
All reactions