Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-agent-blocking-rules: update validation for mode field #1089

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

tamas-jozsa
Copy link
Contributor

Description

After following up with Firewall Team, we have agreed, that whitelist mode is the least popular, and we should rather validate against block, challenge, js_challenge, managed_challenge.

These values are also correlating with the public API:
https://api.cloudflare.com/#user-agent-blocking-rules-create-a-user-agent-blocking-rule

And the Terraform Provider:
https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/provider/schema_cloudflare_user_agent_blocking_rules.go#L33

Has your change been tested?

Swapped the library locally and tested new validations.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

changelog detected ✅

@jacobbednarz jacobbednarz merged commit eceec5d into master Sep 21, 2022
@jacobbednarz jacobbednarz deleted the user-agent-blocking-rules branch September 21, 2022 23:16
@github-actions github-actions bot added this to the v0.51.0 milestone Sep 21, 2022
github-actions bot pushed a commit that referenced this pull request Sep 21, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.51.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants