user-agent-blocking-rules: update validation for mode field #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After following up with Firewall Team, we have agreed, that
whitelist
mode is the least popular, and we should rather validate againstblock
,challenge
,js_challenge
,managed_challenge
.These values are also correlating with the public API:
https://api.cloudflare.com/#user-agent-blocking-rules-create-a-user-agent-blocking-rule
And the Terraform Provider:
https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/provider/schema_cloudflare_user_agent_blocking_rules.go#L33
Has your change been tested?
Swapped the library locally and tested new validations.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist: