Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for score_per_period in RulesetRuleRateLimit #1183

Merged
merged 4 commits into from
Jan 29, 2023

Conversation

troymjones
Copy link
Contributor

closes #1182

Description

Adds support for score_per_period and score_response_header_name for Advanced Rate limiting so it is usable by the the Cloudflare Terraform Provider.

What sort of change does your code introduce/modify?

  • [ X ] New feature (non-breaking change which adds functionality)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

changelog detected ✅

CHANGELOG.md Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

PR looks good, thanks! i'm going to hold off merging until we can confirm the stability of this functionality and whether it's ready for inclusion in our SDKs.

@codecov-commenter
Copy link

Codecov Report

Merging #1183 (c7d9206) into master (6153c1e) will decrease coverage by 0.05%.
The diff coverage is 49.38%.

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   49.40%   49.36%   -0.05%     
==========================================
  Files         127      128       +1     
  Lines       12290    12436     +146     
==========================================
+ Hits         6072     6139      +67     
- Misses       4840     4893      +53     
- Partials     1378     1404      +26     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare_experimental.go 0.00% <0.00%> (ø)
rulesets.go 35.09% <ø> (ø)
teams_rules.go 44.94% <0.00%> (-0.52%) ⬇️
utils.go 72.72% <ø> (ø)
cloudflare.go 68.37% <14.28%> (-0.34%) ⬇️
mtls_certificates.go 26.59% <26.59%> (ø)
workers_bindings.go 67.44% <40.00%> (-2.31%) ⬇️
origin_ca.go 57.26% <90.90%> (-2.09%) ⬇️
dns.go 72.72% <96.36%> (+9.00%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 1a80d3b into cloudflare:master Jan 29, 2023
@jacobbednarz
Copy link
Member

appreciate it @troymjones 👏

@jacobbednarz jacobbednarz added this to the v0.60.0 milestone Jan 31, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.60.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support score_per_period in RulesetRuleRateLimit
3 participants