-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for score_per_period in RulesetRuleRateLimit #1183
Add support for score_per_period in RulesetRuleRateLimit #1183
Conversation
changelog detected ✅ |
PR looks good, thanks! i'm going to hold off merging until we can confirm the stability of this functionality and whether it's ready for inclusion in our SDKs. |
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 49.40% 49.36% -0.05%
==========================================
Files 127 128 +1
Lines 12290 12436 +146
==========================================
+ Hits 6072 6139 +67
- Misses 4840 4893 +53
- Partials 1378 1404 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
appreciate it @troymjones 👏 |
This functionality has been released in v0.60.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
closes #1182
Description
Adds support for score_per_period and score_response_header_name for Advanced Rate limiting so it is usable by the the Cloudflare Terraform Provider.
What sort of change does your code introduce/modify?