Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-8918: DNS Firewall: rename origin_ips to upstream_ips #1246

Merged

Conversation

janik-cloudflare
Copy link
Member

This field has been renamed for consistency.

I've renamed the Go field too, but if we want to avoid making a breaking change, we can find a different solution.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

changelog detected ✅

This field has been renamed for consistency.
@janik-cloudflare janik-cloudflare marked this pull request as ready for review March 24, 2023 14:19
@janik-cloudflare janik-cloudflare marked this pull request as draft March 24, 2023 15:55
@jacobbednarz
Copy link
Member

will the API response have a cut over phase where both values will be present? we can update the SDK here but i worry we may be leaving some folks behind on older versions if we don't.

@janik-cloudflare
Copy link
Member Author

Yes, that's the plan (at least 6 months)

@jacobbednarz
Copy link
Member

cool! sounds like a plan to me.

@janik-cloudflare janik-cloudflare marked this pull request as ready for review April 10, 2023 12:37
@janik-cloudflare
Copy link
Member Author

@jacobbednarz, could you hit the merge button for me please? 🙏

@jacobbednarz jacobbednarz merged commit 4d11581 into cloudflare:master Apr 26, 2023
@github-actions github-actions bot added this to the v0.67.0 milestone Apr 26, 2023
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
@janik-cloudflare
Copy link
Member Author

Thanks 🧡

@github-actions
Copy link
Contributor

This functionality has been released in v0.67.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants