-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to pass in a timeout for the API client #45
Comments
I agree! |
Thinking about the maintainability of this in the long term... perhaps we want to make the I think I prefer having the |
or, we can even implement |
fwiw, i personally prefer a constructor argument to a mutable struct field. generally speaking our client is not a state machine; it is instantiated to do a job, is called to do that job, and then is dropped. I'd rather have the whole configuration passed at construction. |
100% agree with Ashley |
Alright, I'll get going with constructor argument then! :) |
This is related to cloudflare/wrangler-legacy#746.
Ideally, users should be allowed to specify the API client timeout period when constructing the API client with
HttpApiClient::new()
. What do you think?The text was updated successfully, but these errors were encountered: