Allow users to pass in a timeout for the API client

[gabbifish]

This is related to cloudflare/wrangler-legacy#746.

Ideally, users should be allowed to specify the API client timeout period when constructing the API client with HttpApiClient::new(). What do you think?

[adamchalmers]

I agree!

[gabbifish]

Thinking about the maintainability of this in the long term... perhaps we want to make the HttpApiClient 's http_client field mutable, so a user of cloudflare-rs can customize this client field themselves however they see fit using https://docs.rs/reqwest/0.8.4/reqwest/struct.ClientBuilder.html. If we move a timeout param into the Http::ApiClient::new() function and build a client there, I do wonder if that will be the beginning of bloating new() with new param arguments.

I think I prefer having the http_api field in HttpApiClient become mut so users can provide their own reqwest::Client with all their custom configs there. What do you think?

[gabbifish]

or, we can even implement HttpApiClient::from(reqwest_client), where reqwest_client is the custom one built by the user?

[ashleymichal]

fwiw, i personally prefer a constructor argument to a mutable struct field. generally speaking our client is not a state machine; it is instantiated to do a job, is called to do that job, and then is dropped. I'd rather have the whole configuration passed at construction.

[adamchalmers]

100% agree with Ashley

[gabbifish]

Alright, I'll get going with constructor argument then! :)