Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotSupportedError when using NODE-ED25519 keys #310

Closed
yusefnapora opened this issue Jul 12, 2022 · 1 comment · Fixed by #311
Closed

NotSupportedError when using NODE-ED25519 keys #310

yusefnapora opened this issue Jul 12, 2022 · 1 comment · Fixed by #311
Labels
bug Something isn't working
Milestone
2.7.0

Comments

@yusefnapora
Copy link
Contributor

When calling crypto.subtle.importKey or crypto.subtle.generateKey with an algorithm of { name: 'NODE-ED25519', namedCurve: 'NODE-ED25519' }, Miniflare fails with a DOMException with name == "NotSupportedError".

I've got a branch locally that fixes this that I'll PR in a bit :)
@yusefnapora yusefnapora mentioned this issue Jul 12, 2022
Merged
@mrbbot
Copy link
Contributor

mrbbot commented Aug 11, 2022

Hey! 👋 Apologies for the delayed response. I've recently returned from a long holiday and am just starting to catch up on issues now. Thanks for reporting this and for the PR. I've put some comments on it. :)

@mrbbot mrbbot added the bug Something isn't working label Aug 11, 2022
@mrbbot mrbbot added this to the 2.7.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

fix NotSupportedError when using NODE-ED25519
2 participants
@yusefnapora @mrbbot