resource/cloudflare_access_rule: remove ability to create user level rules #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rules Prior to this commit, if you omitted `account_id` and `zone_id` it would create a user level access rule. This wasn't noted anywhere and caught a lot of people out prior to releasing the WAF. Here, we are removing that and explicitly requiring a zone or account ID as in most cases, user level rules are the same as account level rules -- just have a different name externally.
|
changelog detected ✅ |
|
This functionality has been released in v4.0.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if you omitted
account_idandzone_idit would create a user level access rule. This wasn't noted anywhere and caught a lot of people out prior to releasing the WAF.Here, we are removing that and explicitly requiring a zone or account ID as in most cases, user level rules are the same as account level rules -- just have a different name externally.