-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expire unused assets with [site]
#459
Labels
enhancement
New feature or request
Comments
filed cloudflare/wrangler-legacy#2214 to revert the change in wrangler1. |
This needs to be redone, there's some subtlety with the implementation that's breaking people's deploys cloudflare/wrangler-legacy#2224 |
Urgh! So we can't rely on the current time given in a Docker container to be accurate!! |
Distributed systems 🤪 |
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Sites/
[site]
definitions, we currently don't do anything with unused assets. This can lead to bloated kv stores, and slower upload times (because we iterate through all keys in the sites kv store when uploading). The fix is to detect unused assets during upload, and add expiration tags on them.Related, we should probably do this for wrangler 1 as well.
Related - cloudflare/wrangler-legacy#2096
The text was updated successfully, but these errors were encountered: