Workers Sites reuploads files on every change

[EverlastingBugstopper]

Using live reload with Workers Sites takes a really long time. It seems that all static resources are re-uploaded on every change, even if the script is the only thing that changed. I also don't see the indicatif changes that were merged here when using live reload. If I use the --verbose flag, I see a bunch of "Preparing" printlns, but it seems like the indicatif progress bar does not increment at the same part of the code.

[ashleymichal]

since live reload already knows what has changed, we can write logic to use that information rather than doing the arduous complete check against what's in KV to decide what files to upload. I would also suggest that we not bother deleting keys from KV during preview sessions, but perhaps consider a clean up step on ^-C that deletes the whole preview namespace. this would decrease the time on live reloads, but not on the initial upload.

this goes pretty well with the work happening on #783 , since that requires we split kv::bucket::sync into two separate operations (upload and bulk delete) around the worker upload.

[EverlastingBugstopper]

+1 on using live reload logic for re-uploading, but I think that we should delete keys from KV during preview so that things that should 404 actually 404 in preview

[ashleymichal]

but I think that we should delete keys from KV during preview so that things that should 404 actually 404 in preview

maybe don't block reload on it tho? idk.

[EverlastingBugstopper]

we could also parallelize the asset manifest creation with https://github.com/rayon-rs/rayon

[ashleymichal]

some of the refactors made for #1115 may help this; namely, that upload_files now takes a list of key value pairs rather than figuring things out itself. i'll explore what i can do to pass the changes from watch to this function rather than running the whole sync against the namespace.

[EverlastingBugstopper]

we sync now and also re-hashing doesnt take as long anymore. closing for now - sites cleanup milestone has better stuff