Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

[custom-builds-rc] handling of configuration options that don't work in modules mode #1842

Closed
xortive opened this issue Apr 9, 2021 · 3 comments
Labels
custom builds feature Feature requests and suggestions timed out

Comments

@xortive
Copy link
Contributor

xortive commented Apr 9, 2021

These options do not have meaning in modules mode. It is unclear what module path we should use for them, as they may not be inside upload_dir. We should warn if they are present when in modules mode.

@xortive xortive added feature Feature requests and suggestions custom builds labels Apr 9, 2021
@ItsiAdam2
Copy link

ItsiAdam2 commented Aug 16, 2021

This should definitely error and explain that imports should be used instead. I would also suggest that documentation is created to explain how to properly use WASM in modules, rather than the dated and obscure templates.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 180 days. It will be closed if no further activity occurs in the next week. Please feel free to comment if you'd like it to remain open, and thank you for your contributions.

@stale stale bot added the timed out label Mar 2, 2022
@admah
Copy link

admah commented Feb 27, 2023

Thanks for reporting this issue! Wrangler v1 is now deprecated and support is only being provided for critical updates or security concerns. As such, we are closing this issue.

New versions of Wrangler are maintained in the workers-sdk repo. If you are running into a similar issue with wrangler v2, please report it in the workers-sdk repo. For more info about wrangler v1 deprecation, please check out our blog post.

@admah admah closed this as completed Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
custom builds feature Feature requests and suggestions timed out
Projects
None yet
Development

No branches or pull requests

3 participants