Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

change Wrangler build directory #206

Closed
xtuc opened this issue Jun 3, 2019 · 9 comments · Fixed by #1677
Closed

change Wrangler build directory #206

xtuc opened this issue Jun 3, 2019 · 9 comments · Fixed by #1677
Labels
feature Feature requests and suggestions

Comments

@xtuc
Copy link
Member

xtuc commented Jun 3, 2019

Currently the built worker end up in ./worker. However, that directory could be used by the user.

I would suggest to hide the directory, it's useful for debugging but not for the user.

@kristianfreeman
Copy link
Contributor

Agreed. I wouldn't be surprised if people defaulted to using worker/ as the workspace for their Workers in larger projects: can we just do .build or something similar?

(Note that whatever change we do will involve some changes to the various templates: they all generally have worker/ in .gitignore)

@xtuc
Copy link
Member Author

xtuc commented Jun 4, 2019

Yes, if I remember correctly even a template uses worker for user code.

Using .build instead sounds good to me. Also using the os tempdir would make sense to me, I don't expect the user to commit them.

@xortive
Copy link
Contributor

xortive commented Jun 19, 2019

People using dollarshaveclub/cloudworker might want to use the output of the build, so maybe a public build directory is potentially a better option here.

@johnelliott
Copy link

Using 1.8.1 I am noticing the same file created in dist/ and worker/ and haven't tracked down what is causing that behavior.

@xtuc
Copy link
Member Author

xtuc commented Mar 9, 2020

@johnelliott it's expected. One is webpack's output the other is wrangler's output

@johnelliott
Copy link

Yeah I saw #640

@ashleymichal ashleymichal added this to the wrangler build milestone May 13, 2020
@stale
Copy link

stale bot commented Jul 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@xortive
Copy link
Contributor

xortive commented Feb 25, 2021

closing since this is addressed by #1677, which will be going out as part of an RC in the near future

@xortive xortive closed this as completed Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests and suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants