-
Notifications
You must be signed in to change notification settings - Fork 337
Suggest re-building node_modules on failed builds where appropriate #428
Comments
ooh good catch. do you think it's worth running |
I've never developed/published a worker before so sorry if I'm misunderstanding something about the workflow... Wouldn't eagerly Seems like the question that needs to be answered is "is something in node_modules wrong?" – If I'm missing some context then I apologize for the distraction. /cc @ashleymichal Related to #765 |
for the moment, we should try outputting a helpful message when these errors occur, such as "encountered error running |
We assume that the existence of
node_modules
in awebpack
project means the dependencies are installed and we don't need to run npm install again. However, if the user does ctrl-c duringwrangler build
,wrangler publish
orwrangler preview
while the npm install stage is running, it is possible to have anode_modules
folder with invalid contents.The text was updated successfully, but these errors were encountered: