Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Change signature of Subdomain::get to return an Option #758

Closed
EverlastingBugstopper opened this issue Oct 3, 2019 · 0 comments · Fixed by #764
Closed

Change signature of Subdomain::get to return an Option #758

EverlastingBugstopper opened this issue Oct 3, 2019 · 0 comments · Fixed by #764
Assignees
@EverlastingBugstopper
Milestone
1.5.0

Comments

@EverlastingBugstopper
Copy link
Contributor

Related to https://github.com/cloudflare/wrangler/pull/747/files

There are a couple of instances in the codebase that still use get that fails if there is no subdomain, those should still fail (no behavior changes) but instead of failing in Subdomain::get the failures should be handled wherever it was called
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Clean up subdomain creation cloudflare/wrangler-legacy
1 participant
@EverlastingBugstopper