-
Notifications
You must be signed in to change notification settings - Fork 337
allow custom webpack config for Workers Sites projects #905
Comments
please correct me (never wrote any rust) but it looks like it's not just the warning which is wrong: https://github.com/cloudflare/wrangler/blob/master/src/commands/build/wranglerjs/mod.rs#L177 let custom_webpack_config_path = match &target.webpack_config {
Some(webpack_config) => match &target.site {
None => Some(PathBuf::from(&webpack_config)),
Some(_) => {
message::warn("Workers Sites does not support custom webpack configuration files");
None
}
}, if webpack is given and worker site is activated then this is the opposite of what the docs are stating:
https://developers.cloudflare.com/workers/tooling/wrangler/webpack/ |
that's a good catch! i'll assign this to me and tackle it friday. sorry for the mismatch, we'll patch it up asap. |
Hello! It looks like this issue was fixed in #957, but I'm still seeing the error when attempting to publish a Workers Site with a custom webpack config. I'm using Wrangler |
That's correct @darrenhebner - you can also build from master using rust with |
Is there any ETA for this to be published to |
Why is this closed? Still seeing this issue |
@acoyfellow You might have to add |
Thsi error message is historical; when wrangler implicitly looked at the root for a custom webpack config, it made sense to disable the functionality for sites since the root would likely contain a config for the app you were deploying, not for the workers site. with this change, though, we should allow custom webpack configs since you are required to declare them in your wrangler.toml. This should be as simple as removing a conditional somewhere in wranglerjs, we just need to triage it.
Originally posted by @ashleymichal in #847 (comment)
The text was updated successfully, but these errors were encountered: