Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

all wrangler commands should accept --verbose flag #975

Closed
ashleymichal opened this issue Dec 18, 2019 · 4 comments
Closed

all wrangler commands should accept --verbose flag #975

ashleymichal opened this issue Dec 18, 2019 · 4 comments
Labels
feature Feature requests and suggestions good first issue Good for newcomers
Milestone

Comments

@ashleymichal
Copy link
Contributor

Even if it doesn't actually change the output, it is jarring to pass this flag and have wrangler complain. we should accept it everywhere and use it where applicable.

@ashleymichal ashleymichal added feature Feature requests and suggestions good first issue Good for newcomers status - PR welcome labels Dec 18, 2019
@ericdeansanchez
Copy link

Hi 👋, could I start on this?

@ashleymichal
Copy link
Contributor Author

@ericdeansanchez i see no reason why not! it should be a pretty straight forward change in main.rs, and a good opportunity to learn clap.rs. feel free to ping here if you want any assistance or suggestions!

@ashleymichal
Copy link
Contributor Author

@ericdeansanchez there are a couple of commands (i don't remember which off the top of my head) that already accept a verbose flag; we should follow the same pattern those use but just kind of... ignore it where it is not already used.

@ericdeansanchez
Copy link

ericdeansanchez commented Dec 18, 2019

Ok, great! And yeah I thought that we could add the --verbose flag as an Arg to all the SubCommands and--verbose will just be ignored silently when passed to an unsupported context.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests and suggestions good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants