This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
refactor: extract upload and deploy to lib modules #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/upload/form/mod.rs
Outdated
| @@ -19,6 +19,7 @@ use project_assets::ProjectAssets; | |||
| use text_blob::TextBlob; | |||
| use wasm_module::WasmModule; | |||
|
|
|||
| // these likely belong elsewhere, perhaps in a mod for project type specific behavior. | |||
There was a problem hiding this comment.
nit: i think we should remove this comment and either file an issue or fix it up in this refactor, thoughts?
There was a problem hiding this comment.
i'm happy to do it in this refactor, i'll put it on my Friday list
There was a problem hiding this comment.
jk we need this in, can make an issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a pure refactor i've been meaning to do for awhile; it pulls a lot of the logic out of the publish command into two lib level modules: upload and deploy. the logic in these is used in a couple of places, and it's starting to make sense to keep it out of the commands modules. this will help with a few issues, including uploading a "draft" when a secret is created for a new project, and a lot of the work around consolidating oddly duplicated logic between preview, dev, and publish.