This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Adds Developing Wrangler section to Contribution Guide #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ispivey
reviewed
May 15, 2020
CONTRIBUTING.md
Outdated
| ## People | ||
|
|
||
| Wrangler is maintained by @ashleygwilliams, and her team, Workers Developer Experience. | ||
| Wrangler is maintained by the Workers Developer Productivity team. The core maintainers are @EverlastingBugstopper and @ashleymichal, and everything that gets merged must be approved by at least one team member. |
There was a problem hiding this comment.
I'd suggest just saying the "Workers" team. It has the benefit of being both true and more inclusive; I also like how it helps abstract the most-relevant concept of "core maintainers" away from Cloudflare's organizational structure.
There was a problem hiding this comment.
I'm not entirely sure it's more inclusive. What about just maintained by Cloudflare?
There was a problem hiding this comment.
could say owned by the Cloudflare Workers team and maintained by anybody who wants to contribute
|
This is great, and an unequivocal improvement 🤗 I'll leave it to you and @ashleymichal to agree on what's good enough to merge, but consider this a 👍 from me. |
EverlastingBugstopper
force-pushed
the
avery/contributing-guidelines
branch
from
2eefc1c
to
81f5bae
Compare
|
Comments should be addressed! |
ashleymichal
approved these changes
May 15, 2020
EverlastingBugstopper
force-pushed
the
avery/contributing-guidelines
branch
from
81f5bae
to
0c794a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay external contributors! Fixes #270