Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Removed unreachable code #1444

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Removed unreachable code #1444

merged 1 commit into from
Jul 10, 2020

Conversation

luanraithz
Copy link
Contributor

Following the commented in #1350.

Every effected command has the following setting:

.setting(AppSettings::SubcommandRequiredElseHelp)

So, Clap should make this kind of validation.

@luanraithz luanraithz requested a review from a team as a code owner July 10, 2020 02:15
EverlastingBugstopper
EverlastingBugstopper approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@EverlastingBugstopper EverlastingBugstopper added this to the 1.11.0 milestone Jul 10, 2020
@EverlastingBugstopper EverlastingBugstopper merged commit b87f31e into cloudflare:master Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luanraithz @EverlastingBugstopper