This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
fix installer #1780
Merged
fix installer #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th updated deps), more detail in release checklist
xtuc
approved these changes
Feb 24, 2021
Co-authored-by: Brayden Phillips <[email protected]> Co-authored-by: Ashcon Partovi <[email protected]> Co-authored-by: Natalie Davidson <[email protected]> Co-authored-by: Sven Sauleau <[email protected]>
|
1.14.0 makes more sense to me... did you have a reason to prefer re-publishing? |
|
to not leave a broken version on npm is all (to be clear, i'm only talking about re-releasing 1.13.0 with the fixed installer that we'll be using from now on, so installing wrangler 1.13.0 from npm will actually do that properly)
…On Wed, Feb 24, 2021 at 11:51 AM Cody Koeninger ***@***.***> wrote:
1.14.0 makes more sense to me... did you have a reason to prefer
re-publishing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKLUPET52OU3MPSNTKDZ3TAU4CRANCNFSM4YE4TYWQ>
.
|
xortive
force-pushed
the
malonso/fix-installer
branch
from
ff568a5
to
d7d2578
Compare
|
looks like unfortunately, it seems like the 1.13.0 binary is exiting with status code 1 despite printing no errors, so npx prints a scary error message after running a wrangler command... EDIT: above problem has something to do with clap, and is benign. it only happens when running |
alexwilson
added a commit
to alexwilson/frontend
that referenced
this pull request
Mar 22, 2021
Following cloudflare/wrangler-legacy#1780 this should no longer be needed. see #1533.
alexwilson
added a commit
to alexwilson/frontend
that referenced
this pull request
Mar 22, 2021
Following cloudflare/wrangler-legacy#1780 this should no longer be needed. see #1533.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] broke semver, this PR changes our installer to use a cloudflare-owned version of binary-install with updated dependencies to resolve the previous vulnerability warnings from the old version of axios that was being used.
Question: should we re-publish [email protected] with the fixed installer, or just proceed to 1.14.0?
closes #1772
closes #1286
closes #1234
closes #1758