This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Downgrade panic when no account IDs match a token to an error #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still not sure exactly how this could happen, and I feel there's a bug here somewhere ... but people are hitting this in practice (enough that someone ran `wrangler report`) and this will help the user experience in the meantime.
caass
approved these changes
Aug 27, 2021
|
Yes, this will still stop wrangler and give a hard error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not sure exactly how this could happen, and I feel there's a bug here somewhere ... but
people are hitting this in practice (enough that someone ran
wrangler report) and this will helpthe user experience in the meantime.
r? @nilslice