Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: show sizes #205

Merged
merged 1 commit into from
Jun 6, 2019
Merged

feat: show sizes #205

merged 1 commit into from
Jun 6, 2019

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jun 3, 2019

Once the build is finished print the size of the script, in gzip, and
Wasm binary size if available.

@xtuc
feat: show sizes
b1376a5 
Once the build is finished print the size of the script, in gzip, and
Wasm binary size if available.
@ashleygwilliams ashleygwilliams added this to the 1.0.1 milestone Jun 4, 2019
ashleygwilliams
ashleygwilliams approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good- do you think we could also do this for the other build pathways? doesn't need to block this- but something i'd like to see!

@ashleygwilliams ashleygwilliams merged commit 12d42a7 into master Jun 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-show-sizes branch June 6, 2019 15:14
@ashleygwilliams ashleygwilliams mentioned this pull request Jun 6, 2019
Closed
@xtuc
Copy link
Member Author

xtuc commented Jun 6, 2019

Sure thing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtuc @ashleygwilliams