This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
fix: remove panic when send fails, log error instead #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Sep 3, 2021
nilslice
force-pushed
the
sm/ew-5091-finish
branch
2 times, most recently
from
8822abf
to
5979ed9
Compare
nilslice
force-pushed
the
sm/ew-5091-finish
branch
from
5979ed9
to
f26e8ae
Compare
jyn514
approved these changes
Sep 14, 2021
nilslice
force-pushed
the
sm/ew-5091-finish
branch
from
f26e8ae
to
52d86e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the panic on send failure from the last remaining place for this particular
--watcherror.