Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Only warn about compatibility dates on publish #2080

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Conversation

Electroid
Copy link
Contributor

Changes the compatibility date warning to only occur when using wrangler publish. We do not want this warning to be sent when using other commands like wrangler tail, etc.

Closes #2078

@Electroid Electroid requested a review from a team as a code owner September 20, 2021 05:18
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should probably have this for dev too, or you risk getting divergent behaviour.
  • This should probably be an error on publish, not a warning (or folks who don't manually publish won't even see it)

@Electroid
Copy link
Contributor Author

Hm, I don't think we should error on publish. While this calls for action, it's not urgent or important enough to break builds. If we were deprecated something that might be one thing, but this will continue to work. I think a warning is fine.

Copy link
Contributor

@ocsfrank ocsfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I also think just a warning should be fine.

@threepointone
Copy link
Contributor

Could you add the warning for dev as well? Let's merge this in and release it right after.

@threepointone threepointone merged commit ce39eeb into master Oct 13, 2021
@threepointone threepointone deleted the fix/2078 branch October 13, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only warn about compatibility date for wrangler publish
4 participants