Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: force flag for kv bulk delete command to avoid user confirmation prompt #2100

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

andersquist
Copy link
Contributor

Adresses #2095. Make it possible to override any user confirmation prompt when performing KV bulk deletes.

@andersquist andersquist requested a review from a team as a code owner October 9, 2021 11:15
@threepointone
Copy link
Contributor

This looks good! I'll do a proper review early next week, thanks so much!

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'll have the team have a look at it as well before merging.

@threepointone
Copy link
Contributor

Could you include this one too @jspspike? Thank you!

@jspspike
Copy link
Contributor

Could you include this one too @jspspike? Thank you!

Yes just finished testing this locally and it seems fine to me, would we want to add this to kv:key and kv:namespace as well? @andersquist

@threepointone
Copy link
Contributor

Good question, I guess... yes?

@andersquist
Copy link
Contributor Author

Sure, for consistency that seems only logical.

I'll update the PR. 👍

@andersquist
Copy link
Contributor Author

The commands kv:namespace delete, kv:key delete as well as kv:bulk delete all have the --force (-f) flag now.

Should I update docs, if so where do I do that?

@jspspike
Copy link
Contributor

@andersquist Awesome I'll take a look, you can update the docs in the Cloudflare docs repo.

Copy link
Contributor

@jspspike jspspike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended, thanks for the PR!

@jspspike jspspike merged commit c6fc0df into cloudflare:master Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants