This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix missing fmt argument in error message #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the error message would literally be 'Your token has
status "{}"' with curly braces in it instead of the token status.
This code was doing two inconsistent things with the bail macro args:
the one in delete.rs used single `{` assuming the string would *not* get
put into std::fmt, while the one in put.rs used double `{{` assuming
that std::fmt *would* get applied to it.
This change closes the inconsistency and makes room for the bail macro
to catch issues like this statically in a future version.
jyn514
approved these changes
Nov 3, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fills in a missing argument to
{}in config.rs. Without this, the error message would literally be 'Your token has status "{}"' with curly braces in it instead of the token status.The second commit closes an inconsistency between how two places were doing bail macro args: the one in delete.rs used single
{assuming the string would not get put into std::fmt, while the one in put.rs used double{{assuming that std::fmt would get applied to it. This change makes room for the bail macro to catch issues like this statically in a future version.The third commit is done by rustfmt; I am guessing the long line changed by the second commit previously made rustfmt fail out without formatting anything in the whole
matchexpression.