-
Notifications
You must be signed in to change notification settings - Fork 337
feat #323: Allow fn & promise from webpack config #325
feat #323: Allow fn & promise from webpack config #325
Conversation
@xtuc can you please review this PR? |
Could you please add the Also, It seems to me that we are duplicating the |
5e9ce30
to
28bb6c3
Compare
Thanks for the feedback! I'll see what I can find on the webpack front. |
Would this mean we would allow for CLI arguments used on the For example, if I run |
That's a good question. I don't think we should support all the webpack-cli arguments in wrangler. I would pass an empty object. Would it make sense to you? Also note that in #220 we are going to support passing an environment, it would be great if webpack could get access to it. |
I think passing an empty object for Additionally, there could be some defaults that get set and merged with webpack-merge. I believe |
28bb6c3
to
bdc59b5
Compare
The PR looks good to me, I would like to wait for #220, so we can pass it into the |
@xtuc — awesome! Is there anything I need to do to fix the CI tests? |
a133aeb
to
53bb60e
Compare
@third774 let's maybe not wait for env to land. I went ahead a merged this change, it will be release soon. |
PR for #323