This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix ignoring exit code from spawnSync - run-wrangler.js #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433
Fixes #335
I had some api key issues while publishing a route to a specific zone.
I realized that the npm "run-wrangler" wrapper, was exiting zero when our api key was incorrect,
when I expected it to exit non-zero.
Looks like "spawnSync" returns an explicit status field, which has to be propagated up in order to
have the correct exit status.
This diff fixes that (removes an unused import, and fixes some quotes).
Reproduction:
After this fix