This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Refactor cloudflare-rs cli to be called from http.rs #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
added
refactor
status - needs review
regression
gabbifish
changed the title
ashleymichal
suggested changes
Nov 5, 2019
EverlastingBugstopper
approved these changes
Nov 7, 2019
…are/wrangler into gabbi/refactor-cloudflare-rs-cli
ashleymichal
approved these changes
Nov 8, 2019
| @@ -61,3 +72,59 @@ fn add_auth_headers<'a>(headers: &'a mut HeaderMap, user: &GlobalUser) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| ////---------------------------NEW API CLIENT CODE---------------------------//// | |||
| pub fn api_client( | |||
There was a problem hiding this comment.
boy do i not want to bikeshed this, but i might suggest lending some specificity for future proofing, like cf_v4_api_client or something. non-blocking
There was a problem hiding this comment.
ooh, i do like this idea... i defs want us to think about this more as a team. Mind if we make a separate ticket for this?
There was a problem hiding this comment.
yes, though being a soon-to-be ubiquitous public function it should be done sooner than later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor to where we call cloudflare-rs logic and methods for handling errors from this library. We move this logic from commands/kv/mod.rs to http.rs so that we can access the cloudflare-rs library beyond the KV module. This is crucial for #439, given that we want to use shared methods between
wrangler kv*andwrangler configto validate that a user's credentials work. Namely, we want to be able to use the same error handling logic of which KV was once the sole user.