-
Notifications
You must be signed in to change notification settings - Fork 337
Do not install wasm-pack for webpack projects #849
Do not install wasm-pack for webpack projects #849
Conversation
@xtuc - would love feedback on the test fixture I've put in here. I plan on making it so that wasm_pack is only installed if the plugin is included in the webpack config. This logic may need to live in wranglerjs itself, but we will need to pass the conditional off to wrangler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense so far
https://github.com/cloudflare/wrangler/blob/master/wranglerjs/index.js#L58 |
e7c8084
to
d2ce52a
Compare
…te-to-shareholder-value
…te-to-shareholder-value
4b916ba
to
b8601c5
Compare
So it seems like the webpack config plugin section looks like this: plugins: [
{
"_ranInitialCompilation": false,
"crateDirectory": "/Users/averyharnish/Documents/work/_tmp/webpack-rust-worker-template/crate",
"extraArgs": [],
"outDir": "pkg",
"outName": "index",
"watchDirectories": [
"/Users/averyharnish/Documents/work/_tmp/webpack-rust-worker-template/crate/src"
],
"watchFiles": [
"/Users/averyharnish/Documents/work/_tmp/webpack-rust-worker-template/crate/Cargo.toml"
],
"wp": {
"_events": {},
"_eventsCount": 0,
"options": {
"aggregateTimeout": 200
},
"watcherOptions": {},
"fileWatchers": [],
"dirWatchers": [],
"mtimes": {},
"paused": false,
"aggregatedChanges": [],
"aggregatedRemovals": [],
"aggregateTimeout": 0
},
"isDebug": false,
"error": null
}
] unfortunately this doesn't really give me too much identifiable information to work with. Additionally - it seems like the output from wranglerjs is only created once you actually run the build, and we want to install |
…nt-by-laying-off-half-of-his-workforce
013adb1
to
6e4ff8e
Compare
6e4ff8e
to
4e2fc39
Compare
…off-half-of-his-workforce' of github.com:cloudflare/wrangler into avery/bob-the-builder-becomes-more-efficient-by-laying-off-half-of-his-workforce
be5c7ea
to
063ab9b
Compare
…nt-by-laying-off-half-of-his-workforce
This is currently blocked on rustwasm/wasm-pack#760 |
…nt-by-laying-off-half-of-his-workforce
…nt-by-laying-off-half-of-his-workforce
…nt-by-laying-off-half-of-his-workforce
This PR will fix #745 and is blocked by the following action items: