Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

[rc] [dev] Dev Server Feature Branch #883

Merged
merged 113 commits into from
Feb 6, 2020
Merged

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Nov 19, 2019

Fixes #845

Wrangler Dev Server -- Feature Branch

Testing Instructions - these should be included in the rc when it gets cut


Testing

Your local rustc -V must be at least 1.39.0. You can update by running rustup update stable.

You can install this branch by running cargo install --git https://github.com/cloudflare/wrangler --branch avery/a-time-sync --debug --force

(eventually that will get merged and you can install from this branch)

Go to a worker directory and run wrangler dev and curl/postman away!

$ wrangler dev --help
wrangler-dev 
👂  Start a local server for developing your worker

USAGE:
    wrangler dev [OPTIONS]

FLAGS:
        --help    Prints help information

OPTIONS:
    -h, --host <host>    domain to test behind your worker. defaults to example.com
    -i, --ip <ip>        ip to listsen on. defaults to localhost
    -p, --port <port>    port to listen on. defaults to 8787

Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good overall! I have a few style pointers, some of which are purely personal preference, and i'm not familiar with all of wrangler, so maybe consistency is better. please pick and choose whichever of these you want to take advice from :)

src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
src/commands/preview/proxy.rs Outdated Show resolved Hide resolved
@EverlastingBugstopper
Copy link
Contributor Author

EverlastingBugstopper commented Nov 19, 2019

thanks for the review @steveklabnik - super super helpful :)

generally we do not have a style in wrangler and i would not describe it as consistent - very happy to follow these style suggestions

@EverlastingBugstopper EverlastingBugstopper changed the title Use async syntax for proxy [proxy] Use async syntax for proxy Nov 20, 2019
@EverlastingBugstopper EverlastingBugstopper changed the title [proxy] Use async syntax for proxy [dev] Use async syntax for proxy Nov 20, 2019
@EverlastingBugstopper EverlastingBugstopper changed the title [dev] Use async syntax for proxy [dev] Use async syntax for dev server Nov 20, 2019
Copy link
Contributor

@ashleymichal ashleymichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@EverlastingBugstopper EverlastingBugstopper merged commit ad3a473 into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the avery/a-time-sync branch February 6, 2020 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dev server
3 participants