This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Alewis/custom webpack config for sites #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
added
changelog - feature
webpack
tests/build.rs
Outdated
| fixture.create_file( | ||
| "workers-site/webpack.worker.js", | ||
| r#" | ||
| module.exports = { context: __dirname, entry: "./index.js" }; |
There was a problem hiding this comment.
should target: webworker in case somebody tries to copy our test suite instead of looking at our docs :)
There was a problem hiding this comment.
should we do that for all of them though? because none of the rest of our tests do this.
There was a problem hiding this comment.
hmm yeah we probably should... if we dont provide a custom config then it should be using it automatically
EverlastingBugstopper
approved these changes
Dec 16, 2019
This was referenced Dec 16, 2019
|
tested with mdx-deck workers sites project with custom webpack to not minify. can confirm this works as expected. will merge when CI passes and release with 1.7.0 |
Co-Authored-By: Sven Sauleau <[email protected]>
…d-entry Better error message when custom webpack fails
delete-merged-branch
bot
deleted the
alewis/custom-webpack-config-for-sites
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #905 . need a followup PR for documenting the expected use of these, because it is not immediately obvious to someone not familiar with webpack (like me).
i also want another followup PR to warn when wranglerjs fails with
Entry module not found, and a user has a site AND a custom webpack config, to tell them to set the context like it is here.