Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current_app_name behavior loses environment variables #60

Open
sartan opened this issue Aug 30, 2018 · 1 comment
Open

current_app_name behavior loses environment variables #60

sartan opened this issue Aug 30, 2018 · 1 comment

Comments

@sartan
Copy link

sartan commented Aug 30, 2018

When the zero-downtime deployment is triggered by the current_app_name property, it does not transfer over the environment variables that were set on the currently deployed app. This results in loss of any environment variables which were set via cf set-env rather than by the manifest or pipeline.

One could say that this is by design, however it runs counter to the cf push behavior, which maintains any currently set environment variables that are not present in the manifest.

@kdvolder
Copy link

One could say that this is by design

If it is then it seems odd. Why would rolling deployments not keep the env vars, whereas non-rolling deployments do. If it is 'by design' it would seem more logical to have both cases work the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants