-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing a big file with zero down time consistently fails. #65
Comments
Maybe this is fixed by just bumping the I kicked off a new build - could you try it out? If this is fixed I'll publish a new release. resource_types:
- name: cf
type: docker-image
source:
repository: concourse/cf-resource
tag: dev |
Unfortunately it does not fix it. I did try before as well, with a docker image having latest CLI and the Autopilot plugin: run cf push it works, run cf zero-downtime-push it does not. It's not a huge emergency right now for us, as it's not an app that desperately needs the zero downtime, and in the worst case I would implement my own zero downtime. But it would be nice to get to the bottom of it. Thanks! |
I also faced the issue of trying to push a docker container with zero down time, and it's something that autopilot does not support either. So I forked the resource and applied the following commit: Is it a change that would be considered? My current implementation probably doesn't cover all the edge cases that autopilot did (what if an app called venerable exist, et c.), but it shells out to the cf cli for everything instead. |
Created a pull request to fix it |
Whenever trying to push a pretty big app with a lot of files, the zero down time deployment fails.
When looking at the logs, the request for resource_match never comes back with a response.
If pushing without zero downtime, the cf cli handles the failure to do resource_match appropriately.
I think this is because of the fixes in the CLI for the following issues -
cloudfoundry/cli#1042
cloudfoundry/cli#1123
In our case we are facing the issues that were faced in this issue:
cloudfoundry/cli#1123
The text was updated successfully, but these errors were encountered: