KAPP annotations are deleted in the MutatingWebhookConfiguration

[danail-branekov]

Hello,

We (@cloudfoundry-incubator/eirini) used to implement a webhook of ours using EiriniX. Due to various reasons we decided to drop EiriniX support in favour of using static webhook yml templates. While doing that we noticed that when deployed on cf-for-k8s, the MutatingWebHookConfiguration managed by EiriniX gets its KAPP related annotations. As a consequence, KAPP does not "feel" responsible to manage the web hook and therefore changes in the webhook in future releases (such as renaming, deleting, etc.)

Note that there is no such issue for webhooks that are managed via static yml templates, they are successfully annotated with KAPP labels/annotations and KAPP is successfully managing them.

Further details in this slack discussion

Steps to reproduce:

1. Deploy cf-for-k8s v2.0.0 (no matter on what IAAS, kind is also just fine)
2. Check the eirini-x-mutating-hook mutating webhook configuration - it is missing all KAPP labels and annotations
3. Inspect the output of kapp inspect -a cf to verify that KAPP is not aware of that webhook