-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current droplet guid in apps relationships #3860
Comments
The question is, if it should be allowed to delete the current droplet at all? @stephanme @Gerg @sethboyles - I think it might make sense to add a check to |
I've created a PR (#3926) that clears the |
I've created a PR (#3960) that prevents the deletion of the current app droplet. |
Issue
There is no way to bundle current droplets and applications using
/v3/apps
and/v3/droplets
.Context
The only way to retrieve the current droplet of an application via the API is to go through the
/v3/apps/:app_guid/droplets/current
or/v3/apps/:app_guid/relationships/current_droplet
endpoints.In a context where we want to retrieve all the applications (more than 3000 in my case) and their current droplet, it is therefore necessary to make one request per application (more than 3000 requests).
Possible Fix
Add relationship information with a current droplet in API responses displaying apps.
This can be added quickly by making the
droplet_guid
field of theapps
table visible via the API, but this field is not updated when the current droplet is deleted and at this point, I don't know how to handle this correctly in the DeleteActionJob.Example :
droplet_guid
field in the database is still here, even if the droplet no longer exists.The text was updated successfully, but these errors were encountered: