allow empty app_domains again

[ampersand8]

Issue
Since the commit ab24f0a3bab0f49abcb05a43968bb52d1d65592a it's mandatory to set at least one app domain in cf.yml. So we're currently forced to set a fake domain, which is visible but not of any use to the customer.

Context
Deployment of cf with bosh with capi 1.7.0. when no app_domain is set in cf.yml.

Solution suggestion
I would suggest to revert commit ab24f0a3bab0f49abcb05a43968bb52d1d65592a, so that people can choose whether or not they want to set an app_domain as PaaS provider.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/133771663

The labels on this github issue will be updated when the story is started.

[SocalNick]

Hi @ampersand8 - I think we can remove this constraint. We were trying to improve the seeding code to allow a subdomain of the system domain, but I don't think the requirement of having app_domains is necessary.

CAPI, whoever picks this up, I think it's ok to revert that commit, please let me know otherwise.

[nicregez]

Thanks a lot @SocalNick for helping us with this issue.
By when are you going to release it, or more precisely, in which CF release will we see this fixed?

[SocalNick]

Best I can do is "upcoming release". The CAPI team has been struggling a bit with CI which has caused acceptance to pile up. Thanks for your patience in the matter.

[SocalNick]

Fixed in https://github.com/cloudfoundry/capi-release/releases/tag/1.12.0