Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce linting rules on commits with Husky or Github actions #21

Open
Paul-Hebert opened this issue Dec 10, 2019 · 0 comments
Open

Enforce linting rules on commits with Husky or Github actions #21

Paul-Hebert opened this issue Dec 10, 2019 · 0 comments
Labels
✨ enhancement New feature or request

Comments

@Paul-Hebert
Copy link
Member

The project has linting, but it would be nice to enforce this when users try to commit or push.

@calebeby recommended using a Github action over Husky:

Husky bugs me because it really slows down when I want to commit. On decathlon when we were using husky it often took 8-10 seconds to run the checks when I was trying to commit. We switched to GitHub Actions. Then the checks can run concurrently with PR review, and they enforce that everything works even with the latest dependencies. Also it is nice to be able to commit WIP work even if linting is failing

@Paul-Hebert Paul-Hebert added the ✨ enhancement New feature or request label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant