Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve 'lodash/cloneDeep' import #421

Open
mmmulani opened this issue Aug 22, 2021 · 4 comments
Open

Unable to resolve 'lodash/cloneDeep' import #421

mmmulani opened this issue Aug 22, 2021 · 4 comments

Comments

@mmmulani
Copy link

Not sure if this bug is caused by my setup or how module resolution works in node (it seems like this is an unclear area), so apologies if this is a false report.

But when I try to use @cloudinary/base in my Next.js project, I get an error about failing to resolve lodash/cloneDeep, and then indeed I see that various places import it like lodash/cloneDeep: https://github.com/cloudinary/cloudinary-js-base/search?q=lodash%2FcloneDeep

but in the package dependencies, it is written as lodash.cloneDeep. Should this be switched to import cloneDeep from 'lodash.cloneDeep';?

I monkey-patched the files locally and changing the import statements to lodash.cloneDeep fixed the issue. I also was able to get the package working locally by just installing lodash to my whole project.

@momoip
Copy link

momoip commented Aug 24, 2021

Hi,
Would you try and it should resolve this issue.
npm i lodash
Please let me know if this works.
Thanks,
Mo

@mmmulani
Copy link
Author

hey, installing lodash works but it seems like this should be included in the package.json for this package then?

@momoip
Copy link

momoip commented Aug 25, 2021

Good idea. I will pass it on to our Dev team.
Thanks.

@ghost
Copy link

ghost commented Aug 25, 2021

@mmmulani thanks for reporting this issue, we've merged a fix and it will be part of the next version:
41dbf2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants