Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent mix of build_env = host / external #687

Closed
nyh opened this issue Nov 25, 2015 · 3 comments
Closed

Inconsistent mix of build_env = host / external #687

nyh opened this issue Nov 25, 2015 · 3 comments

Comments

@nyh
Copy link
Contributor

nyh commented Nov 25, 2015

In usr.manifest.skel we have:

/usr/lib/libgcc_s.so.1: %(gccbase)s/lib64/libgcc_s.so.1
/usr/lib/&/libboost_filesystem.so.1.55.0: %(miscbase)s/usr/lib64/&
/usr/lib/&/libboost_regex.so.1.55.0: %(miscbase)s/usr/lib64/&

However,

  1. Taking libgcc_s.so.1 from %(gccbase), i.e, external/, is only the right thing to do for build_env=external. For build_env=host (the default), we should take the system's libgcc_s.so.1. See the code that sets the "libgcc.a" variable, and we should find libgcc_s.so.1 similarly.
  2. If boost_env=host, we take boost libraries and header files from the build system, so we shouldn't take these two boost libraries from external...By the way, I don't know why we're adding them at all - perhaps they are use in one of our tools like cpiod.so and friends?
@wkozaczuk
Copy link
Collaborator

@nyh,

Given that "external" does not exist anymore in Makefile, module.py files as I submitted many patches to eliminate it from everywhere (I think) and given that #743 is closed, shall we close this one as well?

@wkozaczuk
Copy link
Collaborator

@nyh Closing for the reasons explained above. I hope you agree this can be closed.

@nyh
Copy link
Contributor Author

nyh commented May 21, 2020

Indeed, the offending lines don't exist in usr.manifest.skel any more, so it's good you closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants